Re: Thread safety

Eino Tuominen wrote:
>
> How about something like this?
>
> #ifdef RANDOM_FILE
> FILE *f = fopen(RANDOM_FILE, "rb");
>
> if (NULL != f) {
> counter = fread(key, 1, key_data_len, f);
> fclose(f);
> }
> #endif

Ok, I have made the modifications and it seems to work correctly now. A
patch is attached.

> How often this function is called? Is it run only in ares_init()? If so,
> it could be better to use /dev/random, or what do you think?

Any opinions on this?

-- 
   Eino Tuominen

? randomize.patch
Index: ares_init.c
===================================================================
RCS file: /cvsroot/curl/curl/ares/ares_init.c,v
retrieving revision 1.68
diff -r1.68 ares_init.c
1336d1335
< char buffer[256];
1339,1342c1338
< size_t i;
< size_t rc = fread(buffer, key_data_len, 1, f);
< for(i=0; i<rc && counter < key_data_len; i++)
< key[counter++]=buffer[i];

---
>     counter = fread(key, 1, key_data_len, f);