I was working off Nov 20. It Iooks like the latest snapshot solves
the crash I was seeing. I'm not entirely sure about the lack of CNAME
tracking, or the lack of a check for the rr_name of each answer. But
I imagine this will work for most DNS replies.
On Mon, Nov 23, 2009 at 4:53 PM, Yang Tse <yangsita_at_gmail.com> wrote:
> 2009/11/23, Larry Lansing wrote:
>> Attached is a patch to make c-ares stop crashing when
>> ares_parse_srv_reply parses a reply containing non-SRV answers. There
>> are still other problems with the SRV code, which I hope to fix in
>> subsequent patches.
> ares_parse_srv_reply() and ares_parse_txt_reply(), which have never
> existed yet in a release version, have undergone big changes relative
> to the CVS base version for which you are providing a patch. Even its
> API has changed.
> I suggest you grab a daily snapshot dated November 24 2009 or later
> from http://c-ares.haxx.se/daily-snapshot and verify its new API and
> implementation, as this is now supposed to be the stable version which
> is about to be released as c-ares 1.7.0.
It's Google: Not only do we re-invent the wheel, we vulcanize our own rubber.
Received on 2009-11-25