Re: IPv6 DNS server

2009/12/1, Cedric BAIL wrote:

> The attached patch add support for IPv6 DNS server. This add support
> for directive like "nameserver 2a01:e00::2" in resolv.conf. I am sorry
> I don't have enough time right now to be sure it work fine with
> version 1.7.0 as I did this patch against 1.6.0.

Just skimming over it, I have a couple of comments...

> + options->servers[i].s_addr = INADDR_LOOPBACK; /* Crappy work around */

Sure you can do better than that.

1.7.0 has just been released, so there should be enough time to verify
that the patch at least works for you. And that it could be used by
everyone else. If you have questions, simply make them and someone
hopefully will be able to help.

> struct server_state {
> - struct in_addr addr;
> + int family;
> + union {
> + struct in_addr addr4;
> + struct in6_addr addr6;
> + } addr;
> ares_socket_t udp_socket;

Probably it would be interesting to use an ares_addr struct there instead.

Cheers,

-- 
-=[Yang]=-