This month's Index
Subject: Re: [PATCH] Allow the use of IPv6 nameservers
Re: [PATCH] Allow the use of IPv6 nameservers
From: Jakub Hrozek <jhrozek_at_redhat.com>
Date: Thu, 25 Feb 2010 18:33:32 +0100
-----BEGIN PGP SIGNED MESSAGE-----
On 02/19/2010 08:23 PM, Yang Tse wrote:
Sorry for the late response, I've been quite busy lately..
> Not all systems have in6_addr, that's the reason for having
Hmm, fair enough. But I noticed that there are many places in c-ares
Anyhow, attached is a second patch that uses ares_in6_addr at least in
> If you expose definitions of addrV4 and addrV6 in ares.h these should
OK, good suggestion.
> It seems that you are using getaddrinfo() to validate an address
Not host name, I used the AI_NUMERICHOST flag. Per man getaddrinfo(3),
It is more or less just a matter of style. I generally dislike having if
Using getaddrinfo there allowed for a protocol-agnostic code. The
> There also seems to be some 'strange' memory management at the
Correct. Sloppy refactoring. Should be fixed.
Thank you for the review! Hopefully, we're getting there :-)