Subject: Re: [PATCH] Make c-ares support more socket options

Re: [PATCH] Make c-ares support more socket options

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Tue, 25 Sep 2007 11:17:06 +0200 (CEST)

On Tue, 25 Sep 2007, Steinar H. Gunderson wrote:

>> Also: is disabling the Nagle algorithm unconditionally really always a good
>> idea?
>
> It's a good question. I've tried digging through the internal logs here, but
> I can't really figure out why it was first added. How often would you want
> to batch DNS requests in the first place, though?

You're right, I figure that's the spot-on answer why disabling Nagle is almost
always a good idea: you're most likely to just do a single-shot DNS
communication and then it'll take a while until the next one is done.

Will you provide an updated patch with the #ifdef and added comment?

-- 
   c-ares -- my preferred DNS asynch resolver library
Received on 2007-09-25