Subject: Re: [PATCH] Report number of timeouts back to the user code

Re: [PATCH] Report number of timeouts back to the user code

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Tue, 25 Sep 2007 12:52:03 +0200 (CEST)

On Tue, 25 Sep 2007, Steinar H. Gunderson wrote:

> The first API-changing patch; it makes ares report the number of timeouts
> for each query back to the user code (we use this for internal statistics
> etc.).

Uhm, if that new argument added to the callback is put last in the function
prototype it should make existing (binary) applications still work fine, won't
it?

Also, I was thinking that perhaps it would make sense to pass on a handle to
the callback and then allow a function from within that function to extract
this info, as then we can easily add more info to become available to the
callbacks in the future without having to change the API again... but then
again, I'm not sure we can come up with more info that'll make sense to make
it worthwhile go through that kind of slight inconveniance for this timeout
counter.

Oh, and I did miss the corresponding update of the man page in the patch!

-- 
   c-ares -- my preferred DNS asynch resolver library
Received on 2007-09-25