Subject: Re: [PATCH] ares_parse_srv_reply

Re: [PATCH] ares_parse_srv_reply

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Mon, 3 Aug 2009 13:57:52 +0200 (CEST)

On Wed, 15 Jul 2009, Jakub Hrozek wrote:

> OK, I'm attaching a new version of the patch which does not use memcpy at
> all. Hope the code is clearer now.
>
> Daniel, can you see any other issues with the patch? Is c-ares upstream
> interested in merging this functionality?

Sorry for the delay. I am interested in getting this merged. I'm just swamped
with work and I need (more) help with c-ares.

In this version of the patch, won't we risk reading a 16bit word from an
un-aligned memory address? I can't see how 'aptr' is guranteed to be aligned
when you do *(uint16_t *) reads from it and that will crash on numerous
architectures. Or am I wrong?

-- 
  / daniel.haxx.se
Received on 2009-08-03