Subject: RE: yangtse: curl/ares ares__get_hostent.c,1.20,1.21

RE: yangtse: curl/ares ares__get_hostent.c,1.20,1.21

From: Guenter <lists_at_gknw.net>
Date: Sun, 11 Oct 2009 21:48:27 +0200

Hi Yangtse,
isnt the change
http://article.gmane.org/gmane.comp.web.curl.cvs/12383
now obsolete after you changed the type of addrlen with
http://article.gmane.org/gmane.comp.web.curl.cvs/12384
??
BTW I just saw that ares__get_hostent.c still uses:
  struct in_addr addr;
  struct in6_addr addr6;
although in ares.h you can read at line 299ff:
/*
 * NOTE: before c-ares 1.6.1 we would most often use the system in6_addr
 * struct below when ares itself was built, but many apps would use this
 * private version since the header checked a HAVE_* define for it. Starting
 * with 1.6.1 we always declare and use our own to stop relying on the
 * system's one.
 */
struct ares_in6_addr {
  union {
    unsigned char _S6_u8[16];
  } _S6_un;
};

shouldnt we change ares__get_hostent.c to use this struct instead of
in6_addr?

Gün.
Received on 2009-10-11