Subject: Re: [PATCH] ares_free_reply (Was: Re: [PATCH] ares_parse_txt_reply)

Re: [PATCH] ares_free_reply (Was: Re: [PATCH] ares_parse_txt_reply)

From: Yang Tse <yangsita_at_gmail.com>
Date: Fri, 20 Nov 2009 02:54:44 +0100

2009/11/20, Jakub Hrozek wrote:

> is there anything I can help with, either with the generic
> free or just polishing the next release in general?

From the general part I'm aware at least of two points right away.

1)

In ares.h there's a comment mentioning that a couple of structs should
be renamed to avoid name space pollution, prefixing ares_ to them.
Obviously the change should be reflected elsewhere, code and man
pages.

Changing the above would not require existing apps to be recompiled,
so theoretically no ABI breakage here, but apps depending on these
could need to be modified to match the new struct name when
recompiled.

So I think it is a good moment to rise the issue and ask if someone is
against this change. Or if we actually prefer it to happen right away.

2)

Man pages should be revisited verifying that the data type of the
prototypes match those present in ares.h, I remember once seeing at
least one discrepancy. Don't really know if there are many
discrepancies but I don't think so.

-- 
-=[Yang]=-
Received on 2009-11-20