On Wed, 30 Jun 2010, Ben Greear wrote:
> Please let me know if you need any further changes before applying this.
I'm sorry its taken me this long to review and respond to this nice work of
yours!
It uses AF_INET6 and 'struct sockaddr_in6' etc unconditionally, and I'm sure
not every old unix system we know have them declared and defined.
It uses 'inet_pton' but it should use 'ares_inet_pton' to work all over.
When you add new files, it seems a bit weird to set the copyright string to
1998 for MIT. I think it would make more sense to use 2010 and copyright
you...
Minor style nitpicks: the patch introduce trailing whitespace on several
places, and some functions have the starting open brace ({) at the end of the
first line (on the same line as the closing parenthesis) instead of
immediately after the newline following the parenthesis.
Apart from that, I'm just a bit sad that *NOBODY* except me seems to be
interested enough to read or comment your work. It makes this whole process a
lot more error-prone, as this is not features I personally need nor will use
and as we don't have any decent test suite for c-ares there's an evident risk
that we introduce flaws.
If c-ares is going to evolve, we cannot have patches reviewed, commented and
pushed by me only.
If the remarks above are taken care of, I'm prepared to push your work into
mainline. Thanks again for your hard work and your patience!
-- / daniel.haxx.seReceived on 2010-07-16