Subject: Re: Bug in ares_data.c of version 1.7.3

Re: Bug in ares_data.c of version 1.7.3

From: Tommie Gannert <tommie_at_spotify.com>
Date: Wed, 25 Aug 2010 08:22:12 +0200

Ben Greear wrote:
>
> How does this look for a fix?
Very good.

>
> diff --git a/ares_data.c b/ares_data.c
> index 6b6fae8..a2477be 100644
> --- a/ares_data.c
> +++ b/ares_data.c
> @@ -145,7 +145,8 @@ void *ares_malloc_data(ares_datatype type)
> ptr->data.addr_node.next = NULL;
> ptr->data.addr_node.family = 0;
> memset(&ptr->data.addr_node.addrV6, 0,
> - sizeof(ptr->data.addr_node.addrV6));
> + sizeof(ptr->data.addr_node.addrV6));
> + break;
>
> default:
> free(ptr);
>
>
> Thanks,
> Ben
>
>

-- 
Tommie Gannert
Team Lead, Backend Engineering
Spotify
This e-mail (including any attachments) may contain information that is
confidential and/or privileged. It is intended only for the recipient(s).
If you have reason to believe that you are not the intended recipient of
this e-mail, please contact the sender immediately and delete the e-mail
from your computer.

Received on 2010-08-25