Subject: Re: Patch for Android NDK build

Re: Patch for Android NDK build

From: Guenter <lists_at_gknw.net>
Date: Mon, 16 Apr 2012 10:37:11 +0200

Hi Wayne,
Am 16.04.2012 10:10, schrieb Guenter:
> Am 16.04.2012 02:37, schrieb Wayne Piekarski:
>> After reading the discussion in the included link, it seems as though
>> some of the older NDKs do not define __ANDROID__ properly.
>>
>> So if we want c-ares to be compatible with older NDK releases, then we
>> should probably test for both __ANDROID__ or ANDROID.
>>
>> If we want to be compatible only with the latest NDK releases, then only
>> __ANDROID__ should be fine.
>>
>> I'm not sure if there was any similar discussion when the similar patch
>> was made to CURL. Perhaps the safest bet would be to check for both?
commited now after I've read the discussion and the curl fix:
https://github.com/bagder/c-ares/commit/995fa144d97a80f87b40a1e335eb72a938026d48

also I've added the ANDROID macro check for my recent changes since at
least the one for sys/select.h is exactly the same as what was in the
curl patch:
https://github.com/bagder/c-ares/commit/7d3f34115657eaf47a21b1a42d515fd2f9776227

thanks, Gün.
Received on 2012-04-16