On Wed, Apr 25, 2012 at 05:44, Daniel Stenberg <daniel_at_haxx.se> wrote:
> On Wed, 25 Apr 2012, Ben Noordhuis wrote:
>
> Thanks for the patch, applied and pushed now!
>
>
>> On a side note, can you guys start using GH pull requests? It's kind of
>> annoying to have to subscribe to yet another mailing list, especially when
>> it's a trivial patch like this.
>
>
> I strongly dislike github pull requests unless the patch has been properly
> reviewed and discussed on the list first (which then pretty much takes away
> the need to send a pull request). A few reasons:
>
> * We want patches to be reviewed, tested and commented by anyone who's
> interested and volunteering: that is anyone on the mailing list can speak
> up. Pull requests on github assume there's a limited core group that does
> such things.
>
> * I don't want annoying merge commits and github pull requests can't even be
> forced to avoid them.
>
> * Merging patches off the list allows us to tweak the commit messages before
> the commits are pushed which makes them better.
>
> * Having the discussions and reviews done on the mailing list gives us a
> much
> better record and unified place where they happen instead of spread out in
> on github.
Thanks for merging, Daniel.
I see your point regarding pull requests. Re: #2 and #3, what I do
with node and libuv is to merge the patch manually (that is, `curl -s
<pull-request-url>.patch | git am`) and squash or reword afterwards.
We used to use the mailing list but, besides being a barrier to entry,
the high volume caused a lot of patches to get missed.
Anyway, thanks again for merging!
Received on 2012-04-25