Re: [PATCH] Extension mechanisms for DNS

2012/7/16 Ghennadi Procopciuc <gprocopciuc_at_ixiacom.com>:
> Any feedback on this patch ?

The new man page contains "ares_mkquery()" in several places.

+.I useedns
+should be nonzero if is used extension mechanisms for DNS (EDNS).

Grammar error.

+ DNS_RR_SET_CLASS(q, useedns);

Briefly reading the EDNS RFC, shouldn't the class be "maximum UDP
payload size?" The docs for "useedns" just says it should be non-zero
to activate EDNS.
The ares_query.c actually sets it to the max UDP size, so I think this
is a documentation bug (and maybe variable name :)

Apart from that, with my limited knowledge of c-ares and EDNS, it looks good.

-- 
Tommie