On Tue, Jun 25, 2013 at 04:06:25PM -0500, René Berber wrote:
>
>
> On 6/25/2013 3:37 PM, Daniel Stenberg wrote:
>
> >On Tue, 25 Jun 2013, Maxim Ruban wrote:
> >
> >>Patch is in attach (pl. let me know if something wrong with it - I've
> >>made it by TortoiseCVS on Windows, and don't know if it's compatible
> >>with Unix-family tools).
> >>
> >>Please, review it and improve if neccessary.
> >
> >I'm very interested in "+1"s or other expressions of acknowledgements as
> >I'm a Windows illiterate and I need help to tell a good fix from
> >something that needs improvements.
> >
> >Given some support on this list, I don't mind to merge and push.
>
> The code uses a goto, which is a no-no if I remember correctly.
>
Why would it be? He uses goto in a very sensible way, as an error
handler. I personally think that's quite safe and readable.
Also, in the current master:
$ git grep goto | wc -l
54
Received on 2013-06-26