Archive Index This month's Index

Subject: Re: Multilib issue with c-ares

Re: Multilib issue with c-ares

From: Jakub Hrozek <jhrozek_at_redhat.com>
Date: Tue, 27 Aug 2013 15:09:56 +0200

On Tue, Aug 27, 2013 at 01:39:01PM +0200, Daniel Stenberg wrote:
> On Tue, 27 Aug 2013, Jakub Hrozek wrote:
>
> >>Now that patch doesn't apply any longer and when I fix it
> >>manually it still causes a compiler warning since there's now
> >>code using CARES_SIZEOF_LONG. I assume you do something else in
> >>Fedora/Red hat?
> >
> >Yes, here is a patch that is used in the Fedora RPMs. For my use
> >it's good enough as it covers the architectures on single platform
> >I maintain. Not sure if it's good enough for upstream.
>
> Right, it assumes that there's a <bits/wordsize.h> header that
> defines __WORDSIZE neither of which we can assume "globally".
>
> How about instead relying on <limits.h> which is POSIX ? See my
> attachment for a fix I belive can work.

If all platforms the upstream is interested in support limits.h (even
those funky HP-UX etc), then this should work, yes.
Received on 2013-08-27