Subject: Re: [PATCH 1/5] Null check before dereference

Re: [PATCH 1/5] Null check before dereference

From: David Drysdale <drysdale_at_google.com>
Date: Mon, 22 Sep 2014 10:53:09 +0100

LGTM

On Fri, Sep 19, 2014 at 7:51 PM, Gregor Jasny <gjasny_at_googlemail.com> wrote:

> Fix Coverity error CID 56880
>
> Signed-off-by: Gregor Jasny <gjasny_at_googlemail.com>
> ---
> ares_options.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/ares_options.c b/ares_options.c
> index 76d82df..cf88433 100644
> --- a/ares_options.c
> +++ b/ares_options.c
> @@ -158,6 +158,9 @@ int ares_set_servers_csv(ares_channel channel,
> return ARES_SUCCESS; /* blank all servers */
>
> csv = malloc(i + 2);
> + if (!csv)
> + return ARES_ENOMEM;
> +
> strcpy(csv, _csv);
> if (csv[i-1] != ',') { /* make parsing easier by ensuring ending ',' */
> csv[i] = ',';
> --
> 1.8.5.2 (Apple Git-48)
>
>
Received on 2014-09-22