Subject: overly forceful checking of CFLAGS vs CPPFLAGS?

overly forceful checking of CFLAGS vs CPPFLAGS?

From: Karl Palsson <karlp_at_tweak.net.au>
Date: Fri, 26 Jun 2015 11:32:44 -0000

Hi,

in OpenWRT projects like FORTIFY_SOURCE have been making inroads, but
c-ares has been a bit of a hiccup. Nothing major, but I'm trying to
keep local changes to packages as minimal as possible, so I wanted to
bring this up here.

The autotools macro m4/xc-val-flgs.m4 is, in my opinion, rather
excessively forceful on aborting the build if it finds any -D flags in
CFLAGS, when it wants them to be only in CPPFLAGS.

Does this _really_ need to be a fatal error? (Does it even need to be
checking this at all?)

See https://github.com/openwrt/packages/pull/1464 and the two different
approaches there.

Sincerely,
Karl Palsson
Received on 2015-06-26