On Wed, Jan 13, 2016 at 2:55 PM, Brad House
<brad_at_mainstreetsoftworks.com> wrote:
>>> Would it make sense to create a new release?
>>
>> Yes it would!
>>
>> There have been a bunch of patches flying around that I personally haven't paid much attention to. Is there anything important we should make sure to get done before we ship ?
>>
>
> There was a patch by cosmo.shih_at_gmail.com that hit the mailing list in May 2014
> that fixed some Windows DNS issues with disabled interfaces. It doesn't appear
> that ever hit Git master.
>
> We've been using that patch in production for the last year or so and it definitely
> corrected the issues we were having. We stripped out the
> RegQueryValueEx -> RegQueryValueExA changes though as we didn't have time to
> evaluate such implications, the other part of the patch is the fix we cared
> about ...
>
> -Brad
Ah, I hit that same problem on Windows recently and didn't realize
there had been a
patch floated for it (and so I invented my own way around it).
Given that we've got 2 reports of the patch working (Lei Shi and
Brad), and given that
it also seems to work [1] with the Windows run of the (pending) test
suite, I suggest we
merge it into master. Any objections?
[1] https://ci.appveyor.com/project/daviddrysdale/c-ares/build/1.0.66
Received on 2016-01-13