Subject: Re: [PATCH] Cmake-ify c-ares -- v2

Re: [PATCH] Cmake-ify c-ares -- v2

From: David Drysdale via c-ares <c-ares_at_cool.haxx.se>
Date: Thu, 29 Sep 2016 13:35:37 +0100

On Thu, Sep 29, 2016 at 12:14 PM, Brad House
<brad_at_mainstreetsoftworks.com> wrote:
> On 9/28/16 9:19 AM, Brad House via c-ares wrote:
>>
>> On 9/28/16 7:40 AM, David Drysdale wrote:
>>>
>>> Any pull request will get run through Travis automatically [1], so you
>>> shouldn't need a Travis account.
>>>
>>> If you're not used to Travis, it's probably easier for me to add
>>> something -- first attempt at [2], with output at [3]. Does that look
>>> sensible?
>>>
>>> D.
>>>
>>> [1] https://travis-ci.org/c-ares/c-ares/builds/163269776
>>> [2]
>>> https://github.com/daviddrysdale/c-ares/commit/fc7917e3c5b99ca4f9be66ea5060a2b49a5bbcec
>>> [3] https://travis-ci.org/daviddrysdale/c-ares/builds/163350713
>>>
>>
>> Seems reasonable to me. Built both shared and static variants and test
>> utilities,
>> and tests ran successfully.
>
>
>
> David, should I import your travis modification commit into my repo so it
> is part of the c-ares pull request (64)?
>
> Thanks.
> -Brad

Either that, or I'll just add it to the repo when/if the cmake stuff goes in...
Received on 2016-09-29