Wow, impressive ... I think. Looks like voodoo to me :)
Anyone have thoughts on this? It would mean less to maintain for sure with
multiple build systems, with the caveat of it being hard to fix if it doesn't
work in the future for some reason.
-Brad
On 09/30/2016 02:24 PM, bdoetsch wrote:
> Hey Brad,
>
> I found a cmake function that converts Makefile.inc files into cmake directives, already in use sitting in the curl project (this one is from curl-7.43.0). It allows the CMake build to use all the ".c" and ".h" files already defined in Makefile.inc using a bunch of regex replacements. Not sure how
> resilient it is, but it's working for me on your latest github commit (e46e59454c9e813822052d73e6c77efc731923e8) with macOS 10.11.6. Attached is a patch against your CMakeLists.txt if you're interested in it.
>
> Thought maybe it could help. No worries either way,
>
> Brady
>
>
>
>
> On 9/29/16 6:14 AM, Brad House via c-ares wrote:
>> On 9/28/16 9:19 AM, Brad House via c-ares wrote:
>>> On 9/28/16 7:40 AM, David Drysdale wrote:
>>>> Any pull request will get run through Travis automatically [1], so you
>>>> shouldn't need a Travis account.
>>>>
>>>> If you're not used to Travis, it's probably easier for me to add
>>>> something -- first attempt at [2], with output at [3]. Does that look
>>>> sensible?
>>>>
>>>> D.
>>>>
>>>> [1] https://travis-ci.org/c-ares/c-ares/builds/163269776
>>>> [2] https://github.com/daviddrysdale/c-ares/commit/fc7917e3c5b99ca4f9be66ea5060a2b49a5bbcec
>>>> [3] https://travis-ci.org/daviddrysdale/c-ares/builds/163350713
>>>>
>>>
>>> Seems reasonable to me. Built both shared and static variants and test utilities,
>>> and tests ran successfully.
>>
>>
>> David, should I import your travis modification commit into my repo so it
>> is part of the c-ares pull request (64)?
>>
>> Thanks.
>> -Brad
>