Subject: Re: [PATCH] Cmake-ify c-ares -- v2

Re: [PATCH] Cmake-ify c-ares -- v2

From: Brad House via c-ares <c-ares_at_cool.haxx.se>
Date: Tue, 11 Oct 2016 09:31:21 -0400

On 10/03/2016 02:03 PM, Brad House via c-ares wrote:
> On 10/03/2016 05:23 AM, Gregor Jasny wrote:
>> On 29/09/2016 21:34, Gregor Jasny wrote:
>>> On 29/09/2016 14:34, David Drysdale wrote:
>>>>
>>>> Gregor / Daniel, did you have any thoughts on the CMake change?
>>>
>>> Yes, I'm reviewing it but the CVE took most of my spare time.
>>
>> I think as soon as the latest comments are addressed, the PR is good to
>> be merged. Any later changes could be done incrementally.
>>
>> I'm still no big fan of building shared and static libraries within the
>> same build directory. But this defaults to "OFF" so it does not harm either.
>
> I'm pretty sure everything necessary has been addressed for merging, unless
> anyone has any problems with it.
>
> -Brad
>

Any chance this pull request will be merged before too long? I don't like
letting things just hang around.

Thanks.
-Brad
Received on 2016-10-16