Archive Index This month's Index

Subject: Re: [PATCH] Portability build fix on master (not all systems have socklen_t)

Re: [PATCH] Portability build fix on master (not all systems have socklen_t)

From: Brad House via c-ares <c-ares_at_cool.haxx.se>
Date: Wed, 15 Mar 2017 10:51:16 -0400

Pull request made:
https://github.com/c-ares/c-ares/pull/92

On 3/14/17 8:16 AM, Brad House via c-ares wrote:
> Sure, I've got a couple of meetings this morning, I'll do it this afternoon
> probably.
>
> -Brad
>
> On 3/14/17 8:07 AM, David Drysdale wrote:
>> Hi Brad,
>>
>> Actually, a pull request might be helpful -- that way we get to see the results of a few build combinations on Travis.
>>
>> Thanks,
>> David
>>
>> On Tue, Mar 14, 2017 at 10:50 AM, Brad House via c-ares <c-ares_at_cool.haxx.se <mailto:c-ares_at_cool.haxx.se>> wrote:
>>
>> I didn't think this would be worthwhile for a pull request since its such a trivial
>> patch, but there are a few places where socklen_t is used instead of ares_socklen_t
>> which causes build issues on some legacy platforms. I think this was recently
>> introduced with the virtual socket function implementation.
>>
>> Please see the attached patch.
>>
>> -Brad
>>
>>
Received on 2017-03-15